Skip to main content

I Guess

 
I really enjoyed providing pre-production comments on Rich Rogers' book on quality, Changing Times,  so when the opportunity to do the same for George Dinwiddie came up recently, I took it.

Why? Oh, a handful of reasons, including:
  • I'm here for the testing and reviewing feels a lot like testing. (My definition of testing: the pursuit of relevant incongruity.)
  • There's the interesting intellectual challenge of finding a way to provide the kind of review being requested effectively and efficiently.
  • There's the interesting social challenge of delivering my thoughts in a way that conveys them respectfully, despite sometimes being critical.

George's book is called Software Estimation Without Guessing and I knew up front that there would be two rounds of review for it. The first was on a version with a couple of chapters still to be written, the second with all content present but further editing still required.

The publisher, The Pragmatic Bookshelf, provided clear guidelines on the kind of review they wanted and, in particular, they asked for grammar and typos to be excluded. Initially I felt that this might be a mistake — I could see them, why not point them out and reduce the chance they'd be missed later — but increasingly came to think that it was a good call. By ignoring them, I didn't break my flow to annotate stuff that is probably bread and butter to professional editors, instead delivering what value I could by commenting on the content based on my domain knowledge.

Pragmatic also provided a list of questions, which I decided to treat as an aid to reflection, and so this is how I approached the initial tranche of feedback:
  • I read from the beginning to the end without skipping forwards at all.
  • Along the way, I annotated the manuscript directly with suggestions, criticisms, and things I was wondering about. I hoped that understanding a reader's expectation at different points might be interesting to George in terms of structuring.
  • I didn't read in blocks of less than a chapter.
  • After each chapter, I re-read Pragmatic's questions and, in a separate text file, added fieldstones for each of them, and also for an "Other" category. These comments tended to be at a higher level than those made directly into the draft.
  • When I had read all of the material, I sorted and edited down my answers to the questions.
  • Finally, I reviewed my comments on the manuscript. To make it clear which comments were my first reactions and which had been made with the benefit of hindsight, I flagged this later round with "(2)".

Using Pragmatic's questions to structure my big-picture thoughts was useful even though talking to the editor later I found that they're a reasonably standard set. I treated them essentially as a checklist:
  • Who is the audience for this book? Is the book’s tone appropriate for that audience?
  • Is the book well-organized? Is the material presented in a reasonable order, and does it flow well from one topic to the next? Does the table of contents provide a useful guide?
  • Is the book correct? Are there any technical details that are in error, misleading, or perhaps recently superseded?
  • Is the book engaging? Do you want to keep reading it?
  • Is the book complete? Are there any missing topics, or extraneous topics that should not have been included?
  • Is the book consistent? Is the level of detail consistent and appropriate? How about the audience being addressed?
  • Would you recommend this book to others? Why or why not?

The second round manuscript provided the material that was absent in the first draft, but didn't change the other content. Again, I thought about how to approach it to compromise reasonably between the time I could put in, the coverage I was being asked to provide, and the depth I could go to. This is what I did:
  • I read through only the new chapters, annotating as I went.
  • Again, I read in chapter-length blocks.
  • I read through my answers to the publisher questions from last time.
  • Where it seemed appropriate, I provided new answers in which I was prepared to emphasise, downgrade, add, or remove my originals.
  • I reviewed my comments on the new material looking for inconsistencies between it and earlier comments.

Retrospecting on my methodology, I notice how natural I find this kind of cycle: dive in, record findings and feelings, reflect, choose a level of review and go again. I see it in my day job too. The publisher checklist gave me a structure in this case, but where I don't have one I'll usually distil it from the notes I've recorded.

The human element feels crucial to tasks like this. Beyond some Twitter chat, reading his blog, and watching a recent webinar I don't know George. However I've been on the receiving end of many reviews and know well my sense of indignation and self-righteous rightness when confronted with some thoughtful analysis that contradicts a line I've taken. (This is only amplified when changing my line would involve a lot of work.)

I try to bear this in mind when providing requested feedback, but it can sometimes be hard to balance humility and candour. When in doubt, for this task, I've tried to err on the side of my truth, hoping that'll be more useful to hear, even if it's dismissed.

And that prompts one final thought; although I doubt that he ever had any other intention, I found myself feeling the need to say this to George about my comments: "Ignore anything you want. It's your book!" That's not to belittle my effort, but to reflect the mindset with which I tried to approached the review. It's only my opinion and mentally tagging what I've said with "I guess" can help to remember that, as it's read but also as it's written.
Image: https://flic.kr/p/bTQwf4

Comments

Popular posts from this blog

Can Code, Can't Code, Is Useful

The Association for Software Testing is crowd-sourcing a book,  Navigating the World as a Context-Driven Tester , which aims to provide  responses to common questions and statements about testing from a  context-driven perspective . It's being edited by  Lee Hawkins  who is  posing questions on  Twitter ,   LinkedIn , Mastodon , Slack , and the AST  mailing list  and then collating the replies, focusing on practice over theory. I've decided to  contribute  by answering briefly, and without a lot of editing or crafting, by imagining that I'm speaking to someone in software development who's acting in good faith, cares about their work and mine, but doesn't have much visibility of what testing can be. Perhaps you'd like to join me?   --00-- "If testers can’t code, they’re of no use to us" My first reaction is to wonder what you expect from your testers. I am immediately interested in your working context and the way

Meet Me Halfway?

  The Association for Software Testing is crowd-sourcing a book,  Navigating the World as a Context-Driven Tester , which aims to provide  responses to common questions and statements about testing from a  context-driven perspective . It's being edited by  Lee Hawkins  who is  posing questions on  Twitter ,   LinkedIn , Mastodon , Slack , and the AST  mailing list  and then collating the replies, focusing on practice over theory. I've decided to  contribute  by answering briefly, and without a lot of editing or crafting, by imagining that I'm speaking to someone in software development who's acting in good faith, cares about their work and mine, but doesn't have much visibility of what testing can be. Perhaps you'd like to join me?   --00-- "Stop answering my questions with questions." Sure, I can do that. In return, please stop asking me questions so open to interpretation that any answer would be almost meaningless and certa

Not Strictly for the Birds

  One of my chores takes me outside early in the morning and, if I time it right, I get to hear a charming chorus of birdsong from the trees in the gardens down our road, a relaxing layered soundscape of tuneful calls, chatter, and chirrupping. Interestingly, although I can tell from the number and variety of trills that there must be a large number of birds around, they are tricky to spot. I have found that by staring loosely at something, such as the silhouette of a tree's crown against the slowly brightening sky, I see more birds out of the corner of my eye than if I scan to look for them. The reason seems to be that my peripheral vision picks up movement against the wider background that direct inspection can miss. An optometrist I am not, but I do find myself staring at data a great deal, seeking relationships, patterns, or gaps. I idly wondered whether, if I filled my visual field with data, I might be able to exploit my peripheral vision in that quest. I have a wide monito

Postman Curlections

My team has been building a new service over the last few months. Until recently all the data it needs has been ingested at startup and our focus has been on the logic that processes the data, architecture, and infrastructure. This week we introduced a couple of new endpoints that enable the creation (through an HTTP POST) and update (PUT) of the fundamental data type (we call it a definition ) that the service operates on. I picked up the task of smoke testing the first implementations. I started out by asking the system under test to show me what it can do by using Postman to submit requests and inspecting the results. It was the kinds of things you'd imagine, including: submit some definitions (of various structure, size, intent, name, identifiers, etc) resubmit the same definitions (identical, sharing keys, with variations, etc) retrieve the submitted definitions (using whatever endpoints exist to show some view of them) compare definitions I submitted fro

Testers are Gate-Crashers

  The Association for Software Testing is crowd-sourcing a book,  Navigating the World as a Context-Driven Tester , which aims to provide  responses to common questions and statements about testing from a  context-driven perspective . It's being edited by  Lee Hawkins  who is  posing questions on  Twitter ,   LinkedIn , Mastodon , Slack , and the AST  mailing list  and then collating the replies, focusing on practice over theory. I've decided to  contribute  by answering briefly, and without a lot of editing or crafting, by imagining that I'm speaking to someone in software development who's acting in good faith, cares about their work and mine, but doesn't have much visibility of what testing can be. Perhaps you'd like to join me?   --00-- "Testers are the gatekeepers of quality" Instinctively I don't like the sound of that, but I wonder what you mean by it. Perhaps one or more of these? Testers set the quality sta

Vanilla Flavour Testing

I have been pairing with a new developer colleague recently. In our last session he asked me "is this normal testing?" saying that he'd never seen anything like it anywhere else that he'd worked. We finished the task we were on and then chatted about his question for a few minutes. This is a short summary of what I said. I would describe myself as context-driven . I don't take the same approach to testing every time, except in a meta way. I try to understand the important questions, who they are important to, and what the constraints on the work are. With that knowledge I look for productive, pragmatic, ways to explore whatever we're looking at to uncover valuable information or find a way to move on. I write test notes as I work in a format that I have found to be useful to me, colleagues, and stakeholders. For me, the notes should clearly state the mission and give a tl;dr summary of the findings and I like them to be public while I'm working not just w

Build Quality

  The Association for Software Testing is crowd-sourcing a book,  Navigating the World as a Context-Driven Tester , which aims to provide  responses to common questions and statements about testing from a  context-driven perspective . It's being edited by  Lee Hawkins  who is  posing questions on  Twitter ,   LinkedIn , Mastodon , Slack , and the AST  mailing list  and then collating the replies, focusing on practice over theory. I've decided to  contribute  by answering briefly, and without a lot of editing or crafting, by imagining that I'm speaking to someone in software development who's acting in good faith, cares about their work and mine, but doesn't have much visibility of what testing can be. Perhaps you'd like to join me?   --00-- "When the build is green, the product is of sufficient quality to release" An interesting take, and one I wouldn't agree with in general. That surprises you? Well, ho

Make, Fix, and Test

A few weeks ago, in A Good Tester is All Over the Place , Joep Schuurkes described a model of testing work based on three axes: do testing yourself or support testing by others be embedded in a team or be part of a separate team do your job or improve the system It resonated with me and the other testers I shared it with at work, and it resurfaced in my mind while I was reflecting on some of the tasks I've picked up recently and what they have involved, at least in the way I've chosen to address them. Here's three examples: Documentation Generation We have an internal tool that generates documentation in Confluence by extracting and combining images and text from a handful of sources. Although useful, it ran very slowly or not at all so one of the developers performed major surgery on it. Up to that point, I had never taken much interest in the tool and I could have safely ignored this piece of work too because it would have been tested by

The Best Laid Test Plans

The Association for Software Testing is crowd-sourcing a book,  Navigating the World as a Context-Driven Tester , which aims to provide  responses to common questions and statements about testing from a  context-driven perspective . It's being edited by  Lee Hawkins  who is  posing questions on  Twitter ,   LinkedIn , Mastodon , Slack , and the AST  mailing list  and then collating the replies, focusing on practice over theory. I've decided to  contribute  by answering briefly, and without a lot of editing or crafting, by imagining that I'm speaking to someone in software development who's acting in good faith, cares about their work and mine, but doesn't have much visibility of what testing can be. Perhaps you'd like to join me?   --00-- "What's the best format for a test plan?" I'll side-step the conversation about what a test plan is and just say that the format you should use is one that works for you, your coll

Test Now

The Association for Software Testing is crowd-sourcing a book,  Navigating the World as a Context-Driven Tester , which aims to provide  responses to common questions and statements about testing from a  context-driven perspective . It's being edited by  Lee Hawkins  who is  posing questions on  Twitter ,   LinkedIn , Mastodon , Slack , and the AST  mailing list  and then collating the replies, focusing on practice over theory. I've decided to  contribute  by answering briefly, and without a lot of editing or crafting, by imagining that I'm speaking to someone in software development who's acting in good faith, cares about their work and mine, but doesn't have much visibility of what testing can be. Perhaps you'd like to join me?   --00-- "When is the best time to test?" Twenty posts in , I hope you're not expecting an answer without nuance? You are? Well, I'll do my best. For me, the best time to test is when there